[wellylug] SAA7134

[Ewen McNeill]

In message <Pine.LNX.4.58.0405041827590.10877 at localhost>, David Antliff writes:
>On Mon, 3 May 2004, Ewen McNeill wrote:
>> The section that you quote does also appear in the 2.4.26 patch, however
>> it appears _immediately_after_ the section that the patch applies to [...]
>
>There seems to be an extra loop in your original source:
>	for (retries = 3; retries > 0 && 0 == carrier; retries--)...

Yes, there is a loop like that.  I think inserted to try to avoid the
situation where it doesn't detect the audio carrier (by trying three
times) -- it seems to just make the process slower.

>This doesn't exist in the 2.6.5 driver as far as I can see:

Ah.  You could probably substitute wrapping the code you show in an "if"
statement that only goes into it if the audio_carrier value is not set.

I have had a reply from the author.  He has refused my patch.  He would
prefer to try to make the scan work more reliably.  I think it will
always be vulnerable to random noise, and think the user should have the
option to force the audio carrier setting.  If you find something like
my patch useful you might like to email him (email address in the source
file) and suggest adding a patch like mine.

Ewen